Skip to content

spyOn: install and restore through one writer that throws when the object refuses - #34976

Open
robobun wants to merge 3 commits into
mainfrom
farm/153f7637/test-runner-jest-parity
Open

robobun wants to merge 3 commits into
mainfrom
farm/153f7637/test-runner-jest-parity

Conversation

@robobun

@robobun robobun commented Jul 21, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • spyOn(wasmGcStruct, "x") aborts the process: panic(main thread): abort() called.
  • An index of a frozen array, or a missing module export, returns a spy that is not installed.
  • Cause: JSMock__jsSpyOn and clearSpy (src/jsc/bindings/JSMockFunction.cpp) store with putDirect() and read no result.

Fix

  • Install and restore go through one writer, putOwnPropertyStorage(). A refused store throws a TypeError.
  • A Proxy or a WebAssembly GC object that is not extensible decides through its own defineOwnProperty(). Every other object keeps the direct store.
  • clearSpy() forgets the spy only after the write. restoreAllMocks() restores every spy it can and rethrows the first error.
  • Verified: 10 new tests in test/js/bun/test/mock-fn.test.js and mock/mock-module.test.ts. Main fails 8 and passes the 2 guards.

Background

  • A direct store writes a property without asking the object. It aborts on a WebAssembly GC object, whose Structure cannot change. defineOwnProperty() is the object's own hook behind Object.defineProperty.
  • Weighed: a per-property check before the store, and defineOwnProperty() for every target. Both reject spyOn(Bun, "fetch") and 35 more Bun keys. The writer follows bun test: Vitest compatibility #44833.

Downsides

  • New TypeErrors where a useless spy was returned: an index key on a frozen object, a missing module export, a Proxy over a frozen target. An object that always refuses the restore makes each later restoreAllMocks() throw.
  • A named key on a frozen object stays spy-able, as in 1.4.3 and bun test: Vitest compatibility #44833. Jest throws there. A maintainer must decide (see Notes).
  • Per spyOn + mockRestore pair: +131 instructions (1,929 to 2,060), 0 indirect calls, 0 GC cells. Release binary: +1,408 bytes.
Notes

A debug build prints ASSERTION FAILED: WebAssemblyGCStructure should not do transition for the abort.

Question for a maintainer. The audit line behind this PR said that spyOn on a frozen object installs an inert spy and that Jest throws. Measured on 1.4.3-canary.1, a spy on a named key of a frozen object is not inert: it records calls, mockReturnValue takes effect, and mockRestore puts the original back. Only index keys are inert, and those now throw. #44833 tests frozen and non-extensible targets as spy-able ("consistent with method spies"). So this PR keeps them spy-able. The other choice is one predicate in storesThroughDefineOwnProperty(): send every target that is not extensible through defineOwnProperty(). Then these working spies throw, as in Jest: a frozen own method (bson's frozen EJSON and BSON, 2 of 2 tests pass on main and on this PR), WebAssembly instance.exports, and a restore after Object.freeze.

What changes against main.

call main this PR
spyOn(wasmGcStruct or wasmGcArray, key), named, symbol or index key abort, exit 134 TypeError: Cannot define property for WebAssembly GC object
spyOn(Object.freeze([fn]), 0), also a frozen object with key 0 spy returned, not installed TypeError: Cannot spy on the 0 property because the object does not allow it to be changed
spyOn(moduleNamespace, "notExported") spy returned, not installed TypeError: Cannot spy on the notExported property because the module does not export it
spyOn(new Proxy(Object.freeze({ fn }), {}), "fn") spy returned, not installed TypeError from the target
spyOn(new Proxy(Object.seal({ fn }), {}), "fn") spy returned, not installed spy installed on the target, restored with the same descriptor. The mock keeps the Proxy alive until the restore
spy on index 0, then Object.freeze(array), then mockRestore() no error, spy stays, the mock forgets it TypeError: Cannot restore the 0 property ..., spy stays and stays registered
spyOn(Object.freeze({ fn }), "fn"), also sealed and preventExtensions works, restores same
spyOn(Bun, "fetch"), Bun.env, Bun.version, Bun.argv, Bun.stdout, Math.PI works, restores same

The messages have backticks around the property name.

Measurements. Release builds of main (af5743d) and of this PR (f40e1c9), same machine, same toolchain.

  • Tests on those release builds: main has 97 pass and 7 fail in mock-fn.test.js, and 25 pass and 1 fail in mock/mock-module.test.ts. This PR has 130 pass, 1 todo, 0 fail in both files.
  • spyOn + mockRestore on an extensible object: +131 instructions, +0 indirect calls per pair. Baseline 1,929 (spyOn 1,629, mockRestore 300). This PR 2,060 (1,745 and 315). Direct calls 27 to 31. Method: gdb single-step from entry to return of JSMock__jsSpyOn and jsMockFunctionMockRestore, pairs 41 to 45, 3 runs. perf and valgrind are not installed here.
  • Function text: +1,370 bytes in 11 symbols, and no other symbol changes size (llvm-nm -S on both bun-profile binaries). Smaller: JSMock__jsSpyOn 10,094 to 8,456, JSMock__jsMockFn 1,504 to 874, clearSpy 996 to 614. Larger: JSMock__jsRestoreAllMocks 394 to 448, and the two GC visitors of the mock, 1,984 to 2,173. New: installSpy 1,006, putOwnPropertyStorage 569, addToMockSet 690, throwStoreRefused 1,385, and a copy of PropertyDescriptor::setDescriptor 127.
  • Release binary: +1,408 bytes .text, +1,408 bytes total (llvm-size -A).
  • GC cells per spy pair on an extensible object: +0 (heapStats deltas for Mock, GetterSetter, Function, Object and Structure do not grow from 20,000 to 800,000 pairs on either build).
  • Memory per mock: +0 bytes. The mock has one more field, so sizeof(JSMockFunction) goes from 152 to 160 bytes. Its GC cell is 160 bytes on both builds, because an IsoSubspace rounds the size up to 16 bytes. The GC reads one more field for each mock that it visits.
  • Proxy traps per spyOn on an extensible Proxy: has 1, get 1 on main. This PR adds isExtensible 1 at install and 0 at restore. A Proxy that is not extensible also gets getOwnPropertyDescriptor 1 and defineProperty 1.
  • Bun.* keys that install and restore with the same descriptor: 117 of 118 on main and on this PR. The first version of this PR had 81. The one key is Bun.main, an accessor.
  • Builtin rows that differ from main: 0 of 50 (Bun.*, process.*, console.log, Math.PI, globalThis.NaN, and more).
  • Builtin spy rows that now throw: 3 of 6,364, on 1 object that is not extensible (zlib.codes[0], [1], [2]). The sweep does spyOn + mockRestore on each own data property of 1,321 builtin objects.
  • mock-fn.test.js under jest 30.5.2: the same 5 failures as on main, 47 pass.

Left for later.

  • Other entry points store with putDirect() on an object that Bun did not create, and abort on a WebAssembly GC object in the same way. This PR changes spyOn only.
  • A Proxy over an extensible target still gets a spy that is not installed (bun:test: spyOn throws on missing properties and installs through Proxy #36395).
  • String.prototype.length and require("module")._cache[file] still return a spy that is not installed. The direct store reports success there.
  • A restore of a spy on an inherited method leaves an own property on the object.
  • After spyOn, Object.freeze(object), mockRestore(), a named property is writable and configurable again, as on main.

History of this PR. The first version checked configurable and writable for each property before the store. A review found that it rejected spyOn(Bun, "fetch") and spyOn(Bun, "env"): every entry of bunObjectTable is DontDelete, and about 20 are ReadOnly. The -t change that was in this PR is now #45447.

Other open PRs that edit the same function: #36395, #41396, #31628, #40382, #35449, #44833.


no test proof · iteration 4 · platform-specific test(s) that do not run on this machine, deferring to CI, which covers all platforms: test/cli/test/bun-test.test.ts

@coderabbitai

coderabbitai Bot commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: oven-sh/bun/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9b8b7600-6c34-40d5-abc9-2b9a4d1ab1b1
📥 Commits

Reviewing files that changed from the base of the PR and between a8e68c8 and 67bb721.

📒 Files selected for processing: 2
  • src/jsc/bindings/JSMockFunction.cpp
  • test/js/bun/test/mock-fn.test.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

Spy installation and restoration use shared property-storage logic. Failed restoration throws without clearing spy state, and restoreAllMocks continues processing other spies. Tests and documentation cover rejected writes, restoration retries, and module namespace exports.

Changes

Spy property lifecycle

Layer / File(s) Summary
Spy installation and property storage
src/jsc/bindings/JSMockFunction.cpp, test/js/bun/test/mock-fn.test.js, test/js/bun/test/mock/mock-module.test.ts
Value and accessor spies use shared property-storage logic. Tests cover locked objects, built-in properties, WebAssembly GC objects, and module exports.
Spy restoration and retry
src/jsc/bindings/JSMockFunction.cpp, test/js/bun/test/mock-fn.test.js, docs/test/mocks.mdx
Failed restoration retains spy state. Bulk restoration processes other spies, re-registers failures, and throws the first error. Tests and documentation cover failure and retry behavior.

Suggested reviewers: dylan-conway

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 67bb7

spyOn installation and restoration now share one write path. Refused writes throw instead of returning a spy that was never installed. Restoration failures keep the spy installed so restoration can be retried. No concrete defect remains after review, so the change appears ready to merge, subject to normal CI.

Pre-merge checks: Passed 4
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly summarizes the main change: shared installation and restoration logic that throws when the target refuses the write.
Description check Passed The description clearly explains the problem, implementation, behavior changes, trade-offs, scope, and verification results. It does not use the template headings exactly, but it provides the required…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robobun

robobun commented Jul 21, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 1:21 AM PT - Oct 16th, 2026

❌ @robobun, your commit f40e1c9 has 2 failures in Build #126438 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 34976

That installs a local version of the PR into your bun-34976 executable, so you can run:

bun-34976 --bun

@robobun

robobun commented Jul 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

Status at f40e1c9. The branch is three commits on current main. The -t change moved to #45447.

How to reproduce on a release build of main:

  • Abort: create a WebAssembly GC struct and call spyOn(struct, "x"). The process prints panic(main thread): abort() called and exits with 134. This branch throws TypeError: Cannot define property for WebAssembly GC object.
  • Spy that is not installed: const list = Object.freeze([() => 1]); const spy = spyOn(list, 0). Then list[0] === spy is false. This branch throws a TypeError.
  • Both are in test/js/bun/test/mock-fn.test.js. Main fails 7 of the 9 new tests there, and the new test in mock/mock-module.test.ts. The other 2 are guards that pass on main.

The regression from the first version is gone: spyOn(Bun, "fetch"), spyOn(Bun, "env") and the other read-only builtins work and restore as on main.

CI at f40e1c9 (build 126438) is finished: 179 jobs passed and 2 failed. Neither failure is in code that this PR changes, and no mock test failed or needed a retry on any lane:

One question is open for a maintainer. It is in the Notes of the PR body: should a named key on a frozen object stay spy-able, or throw as in Jest?

Comment thread test/cli/test/bun-test.test.ts Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bugs found, but both changes are user-facing behavior changes (making -t case-insensitive by default, and making spyOn throw on frozen/non-extensible targets where it previously succeeded). Worth a maintainer confirming the parity trade-off is wanted.

What was reviewed:

  • C++ exception-scope handling in the new JSMock__jsSpyOn block — getOwnPropertyDescriptor/isExtensible both have RETURN_IF_EXCEPTION, and the JSModuleNamespaceObject exemption matches the existing write path.
  • Checked that the extensibility check only fires when there is no own property, so spying on a configurable own property of a non-extensible object still works (covered by the third new test) and mockRestore still restores via putDirect.
  • Grepped existing -t usages in bun-test.test.ts — none rely on case-sensitive matching, so no existing assertions flip.
Extended reasoning...

Overview

Two independent jest-parity fixes: (1) src/runtime/cli/Arguments.rs compiles the --test-name-pattern regex with RegexFlags::IgnoreCase instead of None; (2) src/jsc/bindings/JSMockFunction.cpp adds a pre-write check in JSMock__jsSpyOn that throws TypeError when the target own property is non-configurable or the target is non-extensible with no own property, mirroring Object.defineProperty invariants. Three new tests in mock-fn.test.js and one in bun-test.test.ts. My prior nit (test placement inside the .each describe) was addressed in d8f866c.

Security risks

None. No untrusted-input parsing, no allocation sizing, no auth/crypto paths.

Level of scrutiny

Moderate-to-high. The C++ change is small and mechanically correct — every call that can enter JS (getOwnPropertyDescriptor, isExtensible) is followed by RETURN_IF_EXCEPTION, the module-namespace exemption reuses the existing tryJSDynamicCast<JSModuleNamespaceObject*>(object) pattern already present later in the same function, and the check happens before any mutation so nothing needs unwinding on the throw path. However, both changes alter default user-facing behavior: -t foo will now match Foo where it previously did not, and spyOn on a frozen object will now throw where it previously silently proceeded. Per the repo's review guidance around API/behavior changes and "never change a Bun-native default" without deliberation, this is the kind of parity trade-off a maintainer should sign off on rather than an auto-approve.

Other factors

  • CI is green on the touched files across all lanes (per robobun's summary of builds 76987/77012).
  • Docs (docs/test/discovery.mdx, docs/snippets/cli/test.mdx, etc.) don't currently document case sensitivity of -t, so no doc drift, though a note might be worth adding.
  • The three new spyOn tests cover the matrix well (non-configurable own → throw; inherited on non-extensible → throw; configurable own on non-extensible → still works).
  • String(propertyKey.uid()) in the error message will render a symbol's description for symbol keys, which is fine for an error message.

Comment thread src/jsc/bindings/JSMockFunction.cpp Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread test/js/bun/test/mock-fn.test.js Resolved
@robobun

robobun commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator Author

Merged main into the branch. The one conflict was the RegularExpression::init call in Arguments.rs (main now passes the pattern by reference).

The merge showed a real conflict with #37046, which landed after this PR was opened. The single configurable check rejected spyOn(Bar, "prototype") when prototype holds a function (writable, not configurable), and it ran before the prototype error message from #37046. Two of main's tests in mock-fn.test.js failed. aae44c1 replaces the check with one per write path (canWriteSpy): a value replacement needs a writable or configurable property, an accessor needs a configurable property, a new property needs an extensible object. I measured each case against jest-mock 30.5.1. The table is in the description.

Also added a test for spyOn on a WebAssembly GC struct. It aborts release 1.4.2 and canary (WebAssemblyGCStructure should not do transition) and throws a TypeError with this PR.

Ran with a debug build of the merged branch: mock-fn.test.js (92 pass), bun-test.test.ts -t case-insensitively, mock-disposable.test.ts, mock/mock-module.test.ts, regression/issue/08794.test.ts, expect.test.js (416 pass).

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread test/js/bun/test/mock-fn.test.js Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks for the iterations; all three earlier notes (test placement, isBun gating, and try/finally around the global spies) are now addressed.

What was reviewed:

  • canWriteSpy exception discipline: getOwnPropertyDescriptor/isExtensible each guarded with RETURN_IF_EXCEPTION, and both callers bail with return {} before pushImpl/activeSpies registration, so a rejected spy leaves no global state behind.
  • Both write paths (ReplaceValue and DefineAccessor) are gated symmetrically after the module-namespace exemption; the writable-data-descriptor carve-out applies only to the value path, matching the putDirect vs putDirectAccessor invariants.
  • -t → RegexFlags::IgnoreCase is a one-line Jest-parity flip; grepped for existing -t tests relying on case-sensitive non-matching — none found.
Extended reasoning...

Overview

Two independent Jest-parity fixes. In src/jsc/bindings/JSMockFunction.cpp, a new canWriteSpy() helper guards the putDirect/putDirectAccessor/putDirectIndex calls in JSMock__jsSpyOn so that spying on a frozen object, a non-extensible receiver with an inherited method, or a WebAssembly GC struct throws a TypeError instead of silently mutating (or aborting, in the Wasm-GC case). In src/runtime/cli/Arguments.rs, the -t/--test-name-pattern regex is now compiled with RegexFlags::IgnoreCase to match Jest's i flag. Tests land in the existing files for both features (mock-fn.test.js, bun-test.test.ts).

Security risks

None. This is test-runner tooling (spyOn, test-name filtering), not auth/crypto/network. The C++ change strictly narrows behavior — it converts a user-reachable abort() and an integrity-violating write into a catchable TypeError, which is a safety improvement.

Level of scrutiny

Moderate. The C++ side touches JSC bindings, so I checked exception-scope discipline per REVIEW.md: both fallible calls in canWriteSpy are followed by RETURN_IF_EXCEPTION, the helper receives the caller's ThrowScope& by reference, and both call sites return {} on false before any global mock-registry mutation (pushImpl, activeSpies.add). The two write paths are guarded symmetrically, with SpyWrite::ReplaceValue correctly permitting the writable-non-configurable data-descriptor case while SpyWrite::DefineAccessor requires configurable — matching the actual [[DefineOwnProperty]] invariants each putDirect* variant would otherwise skip. The Rust change is a single enum-flag flip with an explanatory "why" comment.

Other factors

This PR has been through four review rounds; each of my earlier notes (test misplaced inside describe(".each"), Bun-only assertions leaking outside if (isBun), and missing try/finally around the Bun.file/Response.json global spies) was addressed by a follow-up commit, verified against the current diff. Test coverage spans the variant matrix REVIEW.md asks for: frozen/sealed/preventExtensions, own vs inherited, function vs non-function, writable-non-configurable builtins with restore verification, and the Wasm-GC abort repro. No outstanding CHANGES_REQUESTED from other reviewers.

Comment thread src/jsc/bindings/JSMockFunction.cpp Resolved
spyOn() and mockRestore() wrote with putDirect(), putDirectIndex() and
putDirectAccessor() and read none of the results. So:

- spyOn() on a WebAssembly GC struct or array aborted the process. Its
  Structure never transitions.
- An index key on a frozen array or object returned a spy that was not
  installed.
- A name that a module does not export also returned a spy that was
  not installed.
- A restore that the object refused left the spy installed, forgot it,
  and stopped restoreAllMocks() before the other spies.

Install and restore now go through one writer, putOwnPropertyStorage().
A Proxy or a WebAssembly GC object that is not extensible decides
through its own defineOwnProperty(). Every other object keeps the
direct store, so a spy on a frozen object with a named key, and on
read-only builtins such as Bun.fetch, works as before. A refused store
throws a TypeError.

clearSpy() writes first and forgets the spy only when the write
succeeded. restoreAllMocks() restores every spy it can, keeps the ones
that were refused, and rethrows the first error.

The single writer with a defineOwnProperty() arm and the restore loop
follow the design in #44833.

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
@robobun
robobun force-pushed the farm/153f7637/test-runner-jest-parity branch from a8762e5 to a8e68c8 Compare October 16, 2026 03:47
@robobun robobun changed the title bun:test: jest-parity fixes for -t filter and spyOn on frozen objects spyOn: install and restore through one writer that throws when the object refuses Oct 16, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline findings, I also checked the new restoreAllMocks collect-and-rethrow loop against the "never clearException" rule: it uses scope.tryClearException(), which leaves termination exceptions in place and returns early, and the first exception is rethrown at the end rather than dropped. The firstException pointer held across later clearSpy calls is a stack local, and the spy snapshot lives in a MarkedArgumentBuffer, so neither is left unrooted while Proxy traps can run.

Extended reasoning...

The commit reworks the spy install/restore path in src/jsc/bindings/JSMockFunction.cpp (new putOwnPropertyStorage/installSpy/addToMockSet helpers, clearSpy now stores before clearing state, restoreAllMocks continues past a refused restore and rethrows the first error) plus tests and docs; it touches no auth, crypto, or injection surface. Five confirmed findings are posted inline and the hunt stopped at its bug cap rather than running dry, so this note only records the two exception-handling and GC-rooting concerns that were examined and ruled out.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread src/jsc/bindings/JSMockFunction.cpp Resolved
Comment thread test/js/bun/test/mock-fn.test.js Resolved
Comment thread src/jsc/bindings/JSMockFunction.cpp Resolved
Comment thread src/jsc/bindings/JSMockFunction.cpp Resolved
Comment thread src/jsc/bindings/JSMockFunction.cpp Resolved
A Proxy can answer the lookup of spyOn() from its `has` and `get`
traps. Then the slot has no attributes, and the value is what the trap
returned. The store through defineOwnProperty() used both, so a spy on
such a Proxy made a non-enumerable method enumerable, and the restore
wrote the value from the trap.

On that path, read the own descriptor of the target. Install and
restore use its attributes, and the restore writes its value. An own
accessor property gets the same error as on an ordinary object.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline finding, I also checked the collect-and-rethrow in restoreAllMocks() against the repo's "never clearException" rule: scope.tryClearException() refuses termination exceptions (so the early return keeps them pending), the first JSC::Exception* is rethrown through throwException, and the MarkedArgumentBuffer snapshot roots every spy across the loop — so it is not swallowing errors.

Extended reasoning...

The diff reworks spy install/restore in src/jsc/bindings/JSMockFunction.cpp to route stores through one writer and throw on refusal, with tests in test/js/bun/test/mock-fn.test.js and mock/mock-module.test.ts and a docs note; it touches no security-sensitive surface. One confirmed finding (weak spyTarget pointing at the Proxy rather than the target on the defineOwnProperty path) is posted inline and a further verified finding is unposted, so approval is not appropriate; this note only records the restoreAllMocks exception-handling check that was examined and ruled out.

Comment thread src/jsc/bindings/JSMockFunction.cpp Resolved
When defineOwnProperty() of a Proxy stores the spy, the spy is in the
target of the Proxy. The mock held the Proxy weakly. If nothing else
kept the Proxy alive, a collection cleared that reference, and
mockRestore() and restoreAllMocks() then did nothing and left the spy
on the target.

The mock now holds such a target strongly until the restore. The same
reference replaces the flag bit that said which path stored the spy.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the latest push (f40e1c9) and found no bugs; the spy-stuck-after-Proxy-collection problem from my previous review is now covered by spyTargetForDefine, which is visited in visitAdditionalChildrenInGCThread and exercised by the new Bun.gc(true) test. Because this rewrites the install/restore path in a JSC binding and the description explicitly leaves a behavior policy (named keys on frozen objects stay spy-able, unlike Jest) for a maintainer to decide, a human look is still worthwhile.

What was reviewed:

  • Exception handling in installSpy, putOwnPropertyStorage, clearSpy and restoreAllMocks: every call that can enter a Proxy trap is followed by RETURN_IF_EXCEPTION or RELEASE_AND_RETURN; the catch-and-rethrow in restoreAllMocks uses scope.tryClearException() and bails on termination, matching the in-tree pattern.
  • Ordering changes in clearSpy (restore before reset(), state cleared only on success) and in restoreAllMocks (set cleared up front, refused spies re-added) against the tests that assert a refused spy stays installed and registered.
  • spyOriginal now being set before install, and the own-descriptor re-read on the defineOwnProperty path, so a lying has/get trap cannot change what restore writes back.
Extended reasoning...

The change touches src/jsc/bindings/JSMockFunction.cpp (spyOn install and restore paths, a new WriteBarrier field with its visitor entry, restoreAllMocks error aggregation), plus new tests in test/js/bun/test/mock-fn.test.js and test/js/bun/test/mock/mock-module.test.ts and one docs paragraph. It touches no security-sensitive surface (no auth, crypto, or data exposure); the risk is GC rooting and exception-check correctness in JSC bindings. The latest commit addresses the one open red finding from the prior run and the bug hunt ran dry with no new findings. Deferring rather than approving because the native refactor is non-trivial and the PR description itself asks a maintainer to decide whether frozen-object named keys should keep being spy-able or throw as Jest does.

Jarred-Sumner added a commit that referenced this pull request Oct 20, 2026
… and CLI (#46021)

### What does this PR do?

Hardening. This collects the open pull requests that fix a crash in Bun
into one change, and fixes about 20 more crashes that had no pull
request.

"Crash" here means a segfault, a Rust panic, an abort, a failed
assertion, memory corruption that a sanitizer reports, a native stack
overflow, or an exception that ends the process and that the program
can't catch. With this PR those cases throw a normal error, print a
normal CLI error and exit 1, or just work.

306 pull requests are included: 227 whole, and 79 cut down to the crash
fix where the rest was a refactor, a feature or a behavior change. Each
one was checked against current `main` first. 45 more turned out to be
fixed already, and 17 were duplicates. The full list is at the bottom.

#### Crashes you could hit in normal use

- **`bun build` with macros and a `.env` file crashed at random.** In a
repro with many macro modules, more than a third of the builds crashed.
Now 3,000 of 3,000 produce the right bundle. (#45960)
- **`bun run` and `bunx` aborted if a signal arrived while the child was
being spawned.** (#38926, #45965)
- **`bun build --compile ./index.js ./public/*` panicked** if an
embedded file's name wasn't valid UTF-8.
- **A truncated or corrupted compiled executable** died with SIGBUS or a
panic at startup. It now prints an error. (#31787, #38251, #41360)
- **Dev server:** several `Option::unwrap()` panics after a failed or
deleted import (#38046, #44744, #44746), a segfault when an `onLoad`
plugin throws while another bundle is queued, a request that hung and
then panicked with `bundle active`, and `server.stop()` that never
resolved after a client aborted a waiting request.
- **`Bun.serve`:** `server.fetch(url, { headers: new Headers() })`
followed by a GC segfaulted (#40888). Routes were used after free after
`server.reload()` with `tls.serverName` (#38636).
- **`text()` and `json()` on a stream of string chunks** could abort the
process, a regression in 1.4.0. (#44269)
- **`Bun.Transpiler` with `exports.eliminate` or `exports.replace`**
aborted on `export default 1` and on most re-export clauses. (#44137)
- **A decorated `declare` field in a class expression** with
`experimentalDecorators` panicked. (#38095)
- **YAML and JSON5 files with a key that isn't a string** panicked with
`--no-bundle` and in `Bun.Transpiler`. (#41827)
- **`Bun.FileSystemRouter`:** reading `.params` segfaulted when a
rejected route candidate left its parameters behind. (#39290, #39291)
- **Native addons that call `uv_async_*`, `uv_timer_*`, `uv_idle_*`,
`uv_prepare_*`, `uv_check_*`, `uv_queue_work` or `uv_cwd`** aborted with
"unsupported uv function" on Linux and macOS. They're implemented now.
(#36609, #39652, #39892)
- **`--watch` and `--hot`** panicked when the system was out of inotify
instances or file descriptors, or when the reload `exec` failed. They
print an error now. (#39629, #39975, #44837)
- **Paths longer than the path buffer** panicked in `bun install`, the
resolver, the bundler, `--compile`, `tsconfig.json` `paths` and
`baseUrl`, `package.json` `main` and `sideEffects`, `bun run --filter`,
`bun pm diff`, source maps and snapshots. They're ordinary errors now,
or they work. (#36340, #37529, #39104, #39650, #43067)
- **A Worker that creates a `ShadowRealm` and imports
`node:worker_threads` in it** segfaulted.
- **`structuredClone` or `postMessage` of an X25519 key** gave an object
that aborted the process when read. (#45624)
- **`node:stream` web adapters and `node:http2`** could end the process
with an exception that no handler could catch. (#45076, #45975)
- **Windows:** a watcher panic in a burst of file changes (#44344), a
segfault after the machine resumes from sleep (#33015), crashes in the
shell's pipe reader (#39638, #43606), and addons that import from
`node.exe` without the delay-load hook (#35618).

Most of the rest needs unusual input: strings near the 2 GiB limit,
buffers that another thread or a getter resizes or detaches in the
middle of a call, `worker.terminate()` at a bad moment, running out of
memory or file descriptors, very deep nesting, or hostile arguments to
`bun:ffi`, `node:vm` and `bun:sqlite`.

#### Behavior changes

Things that didn't crash before and behave differently now:

- `new` on native functions that aren't constructors throws a
`TypeError`, as in Node: `util.types.*`, `buffer.isAscii`, `isUtf8`,
`transcode`, `resolveObjectURL`, `bun:jsc` exports, `cc()` symbols. It
used to return the call's result. They also stop printing as `[class
hostname]`. (#34575)
- `` $`cmd` `` throws `ERR_INVALID_ARG_VALUE` if an environment
variable's name or value contains a NUL byte. It used to cut the value
at the NUL. (#44981)
- `cc()` functions throw a `TypeError` for arguments that used to reach
C as garbage, and `read.*(ptr, NaN)` throws. (#37989, #38057, #40773)
- As PID 1, `bun` exits with 128 + the signal number on Ctrl+C or
`docker stop`. (#38877)
- A `NODE_MODULE` addon that's already loaded by the main thread throws
`ERR_DLOPEN_FAILED` when a live Worker loads it too, as in Node.
(#39968)
- An exception from a `node:vm` context reaches `uncaughtException`
handlers. (#39992) `vm.constants.DONT_CONTEXTIFY` returns the real
global proxy. (#34623)
- `createPrivateKey` rejects an EC JWK whose private value doesn't match
its public point. (#33752)
- `@dec static {}` is a syntax error, as in TypeScript and esbuild.
(#44883)
- `clearTimeout` ignores 0 and negative ids, and timer ids no longer
wrap. (#44771)
- HEAD for a `Response` whose body is an S3-backed `Blob` reports the
length that GET sends. (#44734)
- `bun:sqlite` and `node:sqlite`: if `iterate()` left a write unfinished
on a connection that has a hook, a user function or an authorizer, the
write is finished on the connection's next call instead of during
garbage collection. If the database is gone too, it's rolled back.
- `bun test --bail` runs exit listeners and closes SQLite databases.
(#39010)
- Dev server: a request for a client script waits while a bundle is in
flight (#42733), query strings reach framework routes (#33232), and a
request gets a 500 instead of hanging when plugins fail (#36812).

#### File formats

- `.jsc` bytecode files get a 24-byte footer so they can be verified
before decoding. Files from an older Bun are ignored and the source is
parsed instead. (#39396)
- `node:vm` `cachedData` gets an 8-byte checksum. A blob from an older
Bun is rejected, which the API allows. (#32839)
- The built-in modules section of a compiled executable changes from
format 1 to 2 and carries an engine stamp. (#44907)

#### Performance

Measured in instructions per operation on release builds of this branch
and its base, with an A/A run for the noise floor (0.0 to 0.2 %).

No change: `Bun.serve`, `node:http`, WebSocket echo and publish, `bun
build` of 3,807 modules, `bun run` with 2,000 imports, `readdir` /
`Glob` / `fs.cp` over 23,689 entries, startup and RSS. The binary grows
by 176 KB (0.17 %).

| Faster | Instructions |
| --- | --- |
| WebSocket echo of a 1 MB non-ASCII text message | −72 % |
| `Bun.inspect` of a large non-ASCII string | −39 % |
| `Bun.markdown.html` on large non-ASCII input | −33 % |
| `` $`cmd` `` with 300 environment variables | −6 % |
| `fs.readSync` | −5 % |
| `TextEncoder.encodeInto`, short ASCII strings | −4 % |
| async `crypto.pbkdf2`, 16-byte inputs | −17 % |

| Slower | Instructions | Why |
| --- | --- | --- |
| `cc()` calls | +5 to +51 per call | Argument count and type checks,
and a check for `close()` (#37989, #38057, #43802, #44921). `dlopen()`
calls don't change |
| `process.env.X = v` | 38 → 593 per write | Writes aren't cached. Reads
don't change (#38871) |
| async `crypto.pbkdf2`, inputs of 1 KB or more | +4 to +9 % | Password
and salt are copied (#40554) |
| `bun build` with an object `--define` used thousands of times | +4.5 %
| The object is copied per use (#45969) |

#### Not included

- Fixes that need a WebKit change: #39967, #42534, #42982, #43764,
#43786, #44226. #42185 too: a typed array that has no `ArrayBuffer` yet
can't be pinned, so `view.buffer.transfer()` during an async call can
still free its bytes. Creating the `ArrayBuffer` up front costs 7 to 12
% on every async `fs` call, so the fix belongs in JSC: an `ArrayBuffer`
created while the view is borrowed should start out pinned.
- #45442 (`calc()` sums as a flat list): it changes minified output for
real stylesheets to survive a `calc()` with 25,000 terms. It deserves
its own review.
- #40023 (Windows event loop redesign), #29928 (Windows exit path),
#40534, #43963, #39571, #42904, #42834, #36355, #43266: refactors or
features whose crash is already covered or isn't a crash.
- The pull requests marked *(crash fix only)* below should stay open for
their other half.

### How did you verify your code works?

- **Tests.** Every fix has a test that fails on `main` (a release or an
ASAN build) and passes on this branch, except where that isn't
practical: code that only runs on Windows or macOS, inputs that need
several GB of memory, and a few rare races. Those were checked by hand
or by reading.
- **Stored repro scripts.** 230 crash repros ran on release and ASAN
builds of this branch and of `main`, side by side. Release: 88 no longer
crash. ASAN: 106 no longer crash. None crashes that didn't before. What
still crashes needs WebKit, is SQLite's own bug, or isn't a crash. The
ASAN number is from a later commit than the release number.
- **Dev server.** Because one fix makes requests wait, 2,171 generated
programs ran random interleavings of edits, build errors, failing
plugins, reloads, stops and disconnects with about 120,000 requests. No
request hung, was answered twice or got a stale body. `main` hung in 82
of 1,161 programs. This also found the four dev server bugs listed
above.
- **Path helpers.** 336,000 boundary cases with buffers of exactly the
computed size, and 12,003 random calls through 30 JS APIs on an ASAN
build, compared with `main`. No sanitizer report, and the results match
wherever `main` doesn't panic.
- **What worked on 1.4.3 still works.** Reviewers compared behavior with
1.4.3 and took out what changed it: for example an output directory
layout change for 9 or more entry points, a `server.reload()` change,
and a changed error message for `import("file:///50%deposit.ts")`.
- **Not run locally:** the Windows, macOS and FreeBSD code paths. CI
compiles and tests them.

### Included pull requests

**Bundler, transpiler, CSS, macros** (33)

- #33881 bundler: allocate wrapper_ref for CommonJS modules with no
non-hoistable statements
- #35055 Bun.build plugins: handle filter RegExp flags beyond i/m/v
- #37769 bundler: fail the build instead of panicking when the bundle
thread cannot create its waker
- #37784 bundler: copy inlined env values into the define arena, and
give each Bun.build its own env copy *(crash fix only)*
- #37858 bundler: fail the build instead of panicking when a plugin
answer string cannot be converted
- #38046 bun build --server-components: require the bun target and
reject directives without a framework *(crash fix only)*
- #38095 js_parser: fix panic on decorated declare/abstract fields in
class expressions with experimentalDecorators
- #38966 bundler: keep deep CSS, export star and composes graphs from
overflowing the linker's stack
- #38984 bundler: stop an export star ambiguity that loops back into a
re-export chain from overflowing the stack
- #39113 css: reject stylesheets of 2 GiB or more instead of aborting on
an int cast
- #39396 bundler: frame .jsc bytecode sidecars and verify them before
decoding
- #39855 bundler: join the work still on the pools before the bundle is
torn down *(crash fix only)*
- #41157 dev server: leave out an html link to a cached json module
instead of panicking, and mark a new placeholder file stale
- #41801 css: decode ill-formed UTF-8 to U+FFFD before tokenizing
*(crash fix only)*
- #41827 bundler: handle YAML and JSON5 keys that are not strings
instead of panicking
- #42242 js_parser: compress symbol link chains when following merged
declarations
- #42387 bundler: check receivers on the Bun.build plugin object and
freeze its filters during a build
- #42413 Bounds-check the InternalSourceMap window reader
- #42657 macros: keep visited values alive so a reused address does not
get another value's Expr
- #43330 transpiler: do not print an empty `var` for a data file with no
named export
- #43355 bundler: fix "The memory limit has been exceeded." on large
HTML entries
- #43658 react-compiler: fix skipped functions and build aborts for dead
code in a try body *(crash fix only)*
- #44137 js_parser: fix four crashes of exports.eliminate and
exports.replace
- #44467 js_parser: replace skipped expressions with E::Missing and skip
argument checks after a stack overflow
- #44662 js_parser: walk binary chains on the heap and check the stack
when rewriting decorated #private accesses
- #44712 json5: reject sources of 2 GiB or more before parsing instead
of aborting on an int cast
- #44864 js_parser: walk conditional chains in import()/require() and
define keys in a loop
- #44883 js_parser: reject a decorator on a class static block, keep
decorators out of the body of `declare global` *(crash fix only)*
- #45045 Fix a segfault in new Bun.Transpiler(): re-point options.log
after the constructor moves its Log
- #45604 css: keep a url() in an at-rule prelude as written, and never
print the resolved path of a url() *(crash fix only)*
- #45748 bundler: put --banner/--footer in the bytecode ESM module
record (flags from a parse, entries from JSC) *(crash fix only)*
- #45960 macros: give each parse-worker macro VM its own env loader
- #45969 js_parser: copy object and array defines per use, and copy the
list of a lone JSX spread object *(crash fix only)*

**`bun build --compile` and standalone executables** (3)

- #31787 Don't crash at startup when a standalone executable's embedded
graph is corrupted *(crash fix only)*
- #38251 compile: exit with an error instead of SIGBUS when a standalone
executable is truncated
- #41360 standalone: check every offset in the embedded module graph
before reading it

**Resolver, module loading, plugins, paths** (25)

- #32269 Bun.plugin: validate the namespace without a shared regex
- #33183 bun:jsc: filter internal cells out of getProtectedObjects()
- #34575 Don't register native functions as their own constructors
- #36340 paths: size the thread-local join output buffers to
MAX_PATH_BYTES on Windows
- #37037 mock.module: reject async factory results that are not objects
- #37065 bun:jsc: propagate JSONParse exceptions from
samplingProfilerStackTraces
- #37529 resolver: don't abort on a package.json sideEffects entry
longer than the join buffer
- #38179 node:module: throw instead of crashing when module._compile is
set to a non-function
- #38273 bun test: report a test file or preload the loader cannot
resolve instead of exiting; keep the JUnit report valid U… *(crash fix
only)*
- #38732 paths: compute the common path of 9+ inputs with the same loop
as fewer *(crash fix only)*
- #39228 paths: strip C:\\ down to the drive root in
without_trailing_slash_windows_path *(crash fix only)*
- #39650 bun run --filter: stop panicking on workspace paths longer than
the path buffer
- #40186 resolver: stop deeply nested exports targets from overflowing
the stack
- #40258 resolver: publish Entry.abs_path through the per-entry mutex
- #42183 node:module: reject a _resolveFilename override result that
contains a null byte
- #42401 node:module: accept any `this` in Module.prototype.require
*(crash fix only)*
- #42405 Bun.plugin: transpile a copy of typed array onLoad contents
- #42414 node:module: end the Module._stat path at the first null byte
- #42685 resolver: strip the trailing separator inside bust_dir_cache
- #42735 Throw a RangeError instead of aborting when require.resolve
paths or Worker preload outgrows its Vector
- #43067 Report a path that does not fit a path buffer instead of
aborting *(crash fix only)*
- #44410 Fix a crash when code from a node:vm context reads
require.cache or require.extensions
- #44466 Trace the value an object or data module exports from its
JSSourceCode
- #45044 Bun.plugin: give onLoad's args.path its own bytes
- #45117 cjs: do not call an `__esModule` getter during the annotation
lookup

**Dev server, `bun bake`, routers, `--watch` and `--hot`** (28)

- #28793 Stop file watcher thread before Global.exit tears down memory
*(crash fix only)*
- #32143 bake: fix "Runtime file not found" panic in production builds
of custom frameworks
- #32443 watcher: don't free the Watcher in the spawn-to-start window
*(crash fix only)*
- #33232 bake: normalize the HTTP request-target before matching
framework routes
- #36812 bake: respond 500 and release both RequestContext refs when
on_plugins_rejected / OOM drains a deferred framework r…
- #37039 bake: report per-file print failures in the dev server instead
of serving empty modules
- #37276 hot_reloader: take entries_mutex for watcher-thread directory
cache probes
- #37444 bake: unregister Bake::SourceProvider from the source map table
when it is destroyed
- #39290 FileSystemRouter: match / against a root-level optional
catch-all route *(crash fix only)*
- #39291 FileSystemRouter: order dynamic routes by per-segment
precedence like Next.js *(crash fix only)*
- #39629 watch: report a failed watcher init as an error instead of a
crash
- #41185 bake: check for exceptions in the production build's module
loader hooks and helpers
- #41340 bake: skip the directory watch when the directory cannot be
opened
- #41617 Decide a directory watch event from the watchlist, not from the
resolver's cached listing *(crash fix only)*
- #42547 bake: re-arm the memory visualizer timer when it fires
- #42733 dev server: make a client script request wait for the bundle in
flight
- #42828 bake: serve routes from a router root outside the project root
instead of aborting or answering 404
- #42831 bake: resolve app.root and router roots through one checked
join
- #42836 bake: report route scan errors instead of aborting, and fail
bun build --app on them *(crash fix only)*
- #42840 dev server: map a router type's server entry point to the root
route of that type
- #42862 Bun.serve: return before a pending app.plugins setup() settles
*(crash fix only)*
- #42920 Do not create a mimalloc heap per FileSystemRouter, reload() or
:nth-child(An-B) selector
- #42934 dev server: register a client component without evaluating it
- #43329 dev server: check the route bundle index of a client script URL
before Index::init
- #44249 fs.watch: read each directory and close it before descending
- #44344 Windows: fix a watcher panic and lost events in a burst of file
changes, and a --hot that stops watching a deleted…
- #44744 dev server: answer a cached-file lookup only for a graph that
bundled the file
- #44746 dev server: keep an importer in its own graph when an import
fails or is deleted

**`Bun.serve`, sockets, HTTP, WebSocket, HTTP/2, QUIC, DNS** (28)

- #42667 Reland "usockets(windows): keep a closed poll alive until the
outer tick and libuv are done with it" (#39643)
- #33015 fix(windows): segfault in uv__wake_all_loops after system
resume *(crash fix only)*
- #35761 node:quic: detach lsquic ctx pointers before the finalize-order
sweep at worker VM teardown
- #37082 Bun.serve: terminate FIFO/pipe file responses at EOF
- #38024 dns: keep the c-ares uv_poll_t alive while its poll callback is
on the stack (Windows)
- #38636 serve: fix route use-after-free after reload() with
tls.serverName *(crash fix only)*
- #40888 server.fetch: copy a Headers argument instead of adopting the
wrapper's pointer
- #41337 Update lsquic to 4.9.4 and free unsent stateless resets on
destroy *(crash fix only)*
- #41384 usockets: hold a tick level for the whole of close_all
- #41412 Windows: wait for close completions when closing a worker's uv
loop
- #41516 node:http2: handle an empty byte range in respondWithFile and
respondWithFD
- #41521 udp: report every binaryType from the getter, reject a dgram
bind of the other family *(crash fix only)*
- #42188 net: do not assert a two-character host in SocketAddress.parse
- #42210 libuv(windows): keep a pipe's completed read counted until its
read callback returns
- #42334 fetch, Bun.serve: throw a RangeError for Headers that total 4
GiB or more *(crash fix only)*
- #43738 usockets: close a socket whose resume the kernel refuses from
the loop, not from the caller
- #44338 node:http: response trailers travel with the end call of the
response *(crash fix only)*
- #44433 bake: make the parked-request list non-owning and look up the
DevServer when a plugin load settles
- #44533 node:quic: capture the handshake while the conn is alive, set
the application at session creation
- #44734 Bun.serve: answer HEAD for an S3-backed Blob body without an S3
stat
- #44751 node:quic: close() waits only for opened streams, and lsquic
sends no GOAWAY before HTTP/3 starts *(crash fix only)*
- #44897 node:http2: throw instead of panic when the native
setNextStreamID() misses its argument
- #45076 node:http2: let close() and destroy() win over the refusal of a
request
- #45341 uws: AsyncSocket::write takes a size_t length, so res.end()
sends a body of 2 GiB or more whole
- #45522 node:http2: throw for an ALTSVC frame that is too long and for
a pushPromise id that is not a stream id
- #45676 node:quic: do not reset a stream lsquic has already finished
- #45822 node:quic: name a stream in queued session events by a
per-session key, not by its address
- #45858 Bun.serve WebSocket: a message that does not fit in memory
fails one connection, not the server *(crash fix only)*

**Streams, Blob, S3, files, `node:fs`** (28)

- #33845 io: propagate IoRequestLoop init failure instead of aborting
*(crash fix only)*
- #36365 prompt: drop debug_assert that rejects answers containing CR
- #37090 Deliver FIFO bodies whose writer connects after the reader
opens *(crash fix only)*
- #38039 node:fs: stop fs.copyFile(src, "") from segfaulting on Windows
- #38653 shell(cp): reject copying a directory into itself; walk cp
trees without recursion
- #39207 Convert scope-object receivers in the chaining functions and
inspect.custom fallbacks
- #39390 Blob deserialize: reject over-long paths, treat size >=
MAX_SIZE as unknown, make slice() non-panicking
- #39639 fetch: drop the upload and drain hop refs at VM teardown
*(crash fix only)*
- #40008 inspect hooks: copy user options with putDirectMayBeIndex
*(crash fix only)*
- #40462 Windows: FileSink.start({ path }) on a live writer: hand the
writer a libuv fd and close the old source *(crash fix only)*
- #41440 node:fs: pass the buffer to the read/readv/write/writev
callback on error
- #41584 Walk the timer pairing heap without recursion
- #41608 native-readable: accept a stream with no native handle
- #41710 JSSink write(): convert the chunk before resolving the native
sink *(crash fix only)*
- #42711 webstreams: bound the native recursion through a chain of tees
or text streams
- #43264 fetch: reject a file: URL whose path has an encoded NUL
- #43709 s3: fix double free of a multipart part's bytes on worker
terminate
- #43950 streams: link readers and writers last, reject their promises
as handled
- #44036 PipeReader: label a chunk Eof only when the reader is at its
end
- #44181 streams: throw instead of aborting when a direct stream's text
sink cannot take a string chunk
- #44195 fs: validate POSIX directory records in one parser, report a
malformed record as EIO *(crash fix only)*
- #44269 streams: join the string chunks of a text consumer with one
allocation
- #44490 watch(windows): report a failed child spawn as an error instead
of a panic *(crash fix only)*
- #44954 process.stdout/stderr with no FileSink: write synchronously,
reset after a failed write *(crash fix only)*
- #45004 streams: leave a stream alone when a consumer fails to lock it
- #45521 FileSink: throw ERR_ILLEGAL_CONSTRUCTOR from the constructor
that script reaches by writer.constructor
- #45738 s3: own the Blob store across the calls that run user JS
- #45975 node:stream: do not touch the web controller after the web side
is done

**Node-API, V8 API, `bun:ffi`, `process.dlopen`** (15)

- #36609 napi: implement uv_cwd on POSIX
- #37989 bun:ffi: stop cc() from turning non-numeric pointer arguments
into garbage pointers
- #38057 bun:ffi: make cc() reject non-numeric i64/u64 arguments instead
of passing garbage
- #38425 bun:ffi: throw on an empty cc() source array instead of
panicking
- #39652 napi: implement uv_async_t, uv_queue_work and uv_default_loop
on posix
- #39805 Share one handle scope implementation between Node-API and the
V8 API
- #39892 napi: implement uv_idle_t, uv_prepare_t, uv_check_t and
uv_timer_t on posix
- #40144 bun:ffi: return undefined for a NULL napi_value from cc() and
throw the scheduled napi exception
- #40773 bun:ffi: add the full byteOffset in read.*, do not truncate it
to int32
- #41704 napi: hand the thrown value to
napi_get_and_clear_last_exception after napi_run_script
- #42960 process.dlopen: run a V8 addon's init function after dlopen()
returns
- #43797 Fix debug assertion on an empty error message from a V8 addon
or SQLite *(crash fix only)*
- #43802 bun:ffi: throw a TypeError when a cc() symbol is called after
its library's close()
- #43940 napi: fail with ERR_BUFFER_TOO_LARGE instead of aborting above
the ArrayBuffer limit *(crash fix only)*
- #44921 bun:ffi: pad a short call to a cc() symbol with undefined

**`node:vm`, workers, process, timers** (19)

- #34623 node:vm: run DONT_CONTEXTIFY contexts directly against the real
global
- #32839 node:vm: reject invalid cachedData instead of crashing
- #36921 error printer: clear the pending exception when formatting a
non-Error uncaught value throws
- #37270 error printer: one render per error, [Circular] under the key
that closes the cycle
- #38740 bun:test: give each VM its own fake clock *(crash fix only)*
- #39864 Report a refused HTTP, bundle, IO or process waiter thread as
an error instead of a crash *(crash fix only)*
- #39992 process: deliver exceptions reported against a node:vm context
to uncaughtException
- #41654 node:vm: give each SourceTextModule request the import
attributes of the declaration that created it *(crash fix only)*
- #41739 Do not forward the inherited IPC channel to spawned scripts and
tools
- #41769 node:vm: stop compiling accepted cachedData, report each
cachedData decode to the GC *(crash fix only)*
- #42045 bun:test fake timers: never move the fake clock backwards
- #42308 process.execve: throw instead of aborting for a string past the
string limits
- #42734 node:vm: report cachedData of 2 GiB or more as rejected instead
of aborting
- #42843 process.dlopen: reject a filename of PATH_MAX or more before
dlopen()
- #43500 process: accept SIGSTKFLT, SIGPOLL and SIGPWR, and emit every
name of a signal number *(crash fix only)*
- #44486 worker: stop the start sequence when a handler it calls stops
the worker
- #44771 timers: allocate ids from one 64-bit counter that never wraps
- #44837 --hot: defer a reload during the preloads, and report a reload
that cannot start
- #44991 Fix a use-after-free in the VM ref-string intern for a string
over the length limit

**Shell, spawn, CLI, `bun test`, `bun install`** (31)

- #30642 Fail fast at startup when simdutf has no usable implementation
for this CPU
- #34223 Fix four crashes: HTMLRewriter disturbed body, S3 locked-stream
upload, ConnectionsList closed parser, shell brace… *(crash fix only)*
- #34884 Guard the console and test-runner formatters against native
stack overflow on deeply nested values *(crash fix only)*
- #36584 process.chdir: publish an immutable cwd slice so no thread sees
a torn cwd
- #37135 bun test --parallel: hold the JSC API lock while draining the
worker's final IPC backlog
- #37527 shell(mv): report ENAMETOOLONG instead of panicking when a
source name does not fit the path buffers
- #37528 cli: stop aborting on absolute script paths longer than 1024
bytes on Windows
- #38162 shell(cp): report ENAMETOOLONG instead of panicking on operands
longer than the path buffers
- #38205 shell(windows): report ENAMETOOLONG for operands that do not
fit the path buffer
- #39010 bun test: exit through the VM teardown path when --bail stops a
run
- #39104 bun test: report over-long coverage dir, JUnit outfile and
bunfig root instead of panicking *(crash fix only)*
- #39638 shell(cat): serve a second cat on the same stdin instead of
hanging or panicking
- #39641 usockets: report an out-of-descriptors event loop init as an
error, not a crash *(crash fix only)*
- #40181 shell: stop deeply nested if clauses from overflowing the
parser stack
- #40885 shell: throw instead of panicking when a ReadableStream is used
as a redirect
- #41155 ipc: send a queue item larger than 2 GiB in capped write
requests
- #42298 bun:test: print String objects with 16-bit storage correctly
- #42577 bun:test: root the return values toHaveReturnedWith collects
- #43606 shell(windows): report a failed pipe reader start through
on_reader_error instead of leaking the subprocess *(crash fix only)*
- #43838 node:cluster: read a worker's `ack` and `addressType` in the
primary only when they are int32
- #44172 node:cluster: refuse a descriptor of the wrong kind in the
primary *(crash fix only)*
- #44185 node:cluster: one handle for each descriptor that workers name
*(crash fix only)*
- #44491 bun test: run every callback when native code leaves an
exception pending *(crash fix only)*
- #44694 shell mv: refuse to copy a directory into itself on the
cross-device fallback
- #44752 shell: take the command-substitution capture and drop its NUL
bytes
- #44981 shell: reject NUL bytes in .cwd() and .env() at the native
setters
- #45206 ini: reject a source of 2 GiB or more in Parser::parse instead
of aborting on an int cast *(crash fix only)*
- #45348 bun test: fix a segfault in .not.toThrow(Class) when
Symbol.hasInstance accepts a thrown string, symbol or BigInt
- #45649 shell: replace the output counters in mkdir, cp, ls and touch
with the OutputTask queue
- #45792 bun test: SIGKILL a spawnSync child that is still running 500
ms after the test's timeout *(crash fix only)*
- #45910 create: own the remote-template response buffers instead of
parking them in the CLI arena

**Web APIs, Buffer, encoding, URL, crypto, zlib, SQLite, Redis and the
rest** (96)

- #29709 console: guard JSX/Proxy recursion in Bun.inspect (stack
overflow SIGSEGV)
- #30817 console.takeHeapSnapshot: clear prior snapshots before building
- #30956 spawnSync: make signal-forwarding register/unregister safe for
concurrent callers *(crash fix only)*
- #31505 node:zlib: reject invalid brotli flush values at validation
*(crash fix only)*
- #31735 node:path: fix win32 drive-relative resolve on non-Windows
hosts *(crash fix only)*
- #32085 Fix crash when RedisClient onclose/onconnect is set to a
non-callable
- #32240 Fix BroadcastChannel custom inspect crash with numeric option
keys
- #33181 Reject interior null bytes in Bun.mmap, Glob.scan, and
FileSystemRouter paths *(crash fix only)*
- #33752 node:crypto: validate EC JWK private scalar matches public
point in createPrivateKey
- #34976 spyOn: install and restore through one writer that throws when
the object refuses *(crash fix only)*
- #35562 structuredClone: purify NaN in deserialized Date timestamp so
getTime never returns a forged JSValue
- #35618 napi(windows): load addons that import node.exe without
win_delay_load_hook
- #35757 Coerce later arguments before capturing input buffers in
Bun.Transpiler and Bun.RedisClient
- #37252 Report UTF-16 to UTF-8 encode counts through size_t so exactly
2^32 written bytes doesn't wrap to 0
- #37338 node:module: build require.cache without user-writable globals
and propagate its exceptions *(crash fix only)*
- #37340 redis: accept unsubscribe acks that arrive outside subscriber
mode
- #37370 Error.appendStackTrace: make appending an error's trace to
itself a no-op
- #37443 node:crypto: fix null deref when worker.terminate() lands
during an EC JWK private key import
- #37448 jsc: check for exceptions before using a stored
constructEmptyArray result *(crash fix only)*
- #38009 MessagePort: fix a heap-use-after-free in contextDestroyed(),
release ref() when the last 'message' listener is rem… *(crash fix
only)*
- #38469 napi: settle or refuse async work queued during VM teardown
instead of taking a ticket
- #38708 Handle 16-bit module sources in the error preview, the
new-position fix-up and the REPL *(crash fix only)*
- #38821 process.env: make a failed env build throw instead of aborting
(Windows 0xC0000409 on Bun.$ / Bun.sql / process.env…
- #38871 process.env: coerce to string on every execution of an
assignment, not just the first
- #38877 cli: exit 128 + signo when bun cannot die from a re-raised
signal (bun as container PID 1)
- #38926 Clear the inherited signal mask at startup and exec children
with an empty one *(crash fix only)*
- #39382 Make a failed util.inspect load throw from custom inspect
functions instead of aborting
- #39481 Always create the error when a native error message exceeds the
string length limit
- #39651 performance: keep the user timing entry counts exact after
clearMarks(name) and clearMeasures(name)
- #39775 Turn seccomp SIGSYS traps into ENOSYS so the syscall fallbacks
run on Android
- #39968 process.dlopen: replay a non-context-aware V8 addon only while
no other live VM owns it
- #39975 watch: report a failed reload exec as an error instead of a
panic *(crash fix only)*
- #40346 Give Glob's native scan methods their own private names
- #40554 node:crypto: copy password and salt for async pbkdf2 and scrypt
- #40567 url: reject URL-encoded input over the WTF decode limit instead
of aborting
- #40577 url: throw a RangeError instead of aborting when
URLSearchParams or FormData outgrows its Vector
- #41073 Store array-index property names as indexed properties in
native object builders
- #41137 Write the sampling profiler report at exit from Bun, not JSC's
atexit hook
- #41365 webview: fail only the view when WebKit lacks
initWithDirectory:
- #41574 Decode a private copy of a JS buffer in the UTF-8 decoders
*(crash fix only)*
- #41652 console: read a BigInt depth option by value in console.dir
- #41749 Startup: reopen fd 0-2 as /dev/null only when the fd is closed
- #41819 Report an incoherent BUN_JSC_* option combination as a
configuration error, not a crash *(crash fix only)*
- #42158 webview: reject malformed Chrome replies instead of crashing
- #42179 shell: clamp a `> ${buf}` redirect to the target buffer's live
length
- #42187 node:crypto: throw ERR_OUT_OF_RANGE for >2 GiB buffer arguments
instead of aborting
- #42191 URLPattern: throw instead of aborting when a pattern string
passes the string limit
- #42192 Copy WebAssembly.Memory bytes for native borrows that outlive
the call *(crash fix only)*
- #42198 Make Bun.$, Bun.sql, Bun.postgres and Bun.SQL custom value
getters so reifying the Bun object passes exception chec…
- #42203 node:fs: fs.read into a WebAssembly.Memory view writes into the
block a grow freed
- #42214 Headers: throw a RangeError instead of aborting when the
set-cookie list cannot grow
- #42218 Headers: throw instead of aborting when a value passes the
string length limit
- #42220 URLPattern: throw instead of aborting when the token list
cannot grow
- #42225 Throw ERR_STRING_TOO_LONG from Bun.wrapAnsi instead of aborting
when the output passes the string length limit
- #42226 Throw instead of aborting when a MIME string does not fit in a
string *(crash fix only)*
- #42237 Bun.Cookie: throw instead of aborting when the Set-Cookie
string passes the string length limit
- #42249 Copy a shared input before libdeflate compresses it in
Bun.gzipSync and Bun.deflateSync
- #42253 bun test: walk nested describe scopes without native recursion
- #42259 Throw instead of aborting when a domainToASCII host passes the
string length limit
- #42310 Parse a private copy of a shared or resizable buffer in
Bun.Transpiler, Bun.markdown, Bun.YAML and Bun.TOML *(crash fix only)*
- #42312 YAML, JSON5, XML stringify: throw instead of aborting when the
output passes the string length limit
- #42318 Bound libdeflate's emit path so a racing input cannot overrun
the output
- #42338 inspector: check the type of process.argv in getModuleGraph
- #42364 node:perf_hooks: do not truncate the monitorEventLoopDelay
resolution to int32
- #42412 transpiler cache: reject an entry with no sourcemap section
- #42479 worker_threads: do not abort when
markAsUntransferable/markAsUncloneable gets a WebAssembly GC reference
- #42517 EventTarget: skip a listener object that has no realm
- #42518 fs.Stats: make the date accessors define the property like
Object.defineProperty *(crash fix only)*
- #42575 Stop natives from writing onto a foreign `this` with putDirect:
process.ppid, require.cache, StringDecoder, the nat… *(crash fix only)*
- #42631 JSStringView: pin the cell that owns the borrowed characters
- #42660 bun_core: read /dev/urandom when getrandom(2) answers ENOSYS or
EPERM
- #42780 node:crypto: treat a name too long to convert to UTF-8 as
unknown instead of aborting
- #42782 node:crypto: throw ERR_OUT_OF_RANGE for a passphrase larger
than INT_MAX bytes
- #42856 url: do not abort when a host is too long for the IDNA
conversion buffers
- #42868 sqlite, console, process: do not abort on a string too long to
convert to UTF-8 *(crash fix only)*
- #42941 Bun.sliceAnsi: throw instead of aborting when the result passes
the string length limit
- #43058 Bun.serve: fix crash and cross-request 500 when inspecting a
non-Response return value throws
- #43904 JSC bindings: build property keys from a BunString through
Bun::toIdentifier
- #44124 Bun.Image: decode WebP into a Bun-owned canvas and read ICCP
without the demuxer *(crash fix only)*
- #44190 Convert scope-object receivers before Buffer read*/write* and
vm.Script describe them
- #44211 Stop getsockname(out), useFakeTimers() and the stream source
pull() from writing onto a caller's object with putDirect
- #44295 bun test --coverage: append a final newline to a text that
lacks one *(crash fix only)*
- #44360 rust-argon2: return OutOfMemory instead of aborting when the
memory cost cannot be allocated
- #44421 node:zlib: free zstd's workers before the dictionary they read
- #44521 util.parseArgs: pick the default args start from a per-VM eval
flag, as Node v26 does *(crash fix only)*
- #44740 structured clone: tolerate a zero-sized shared
WebAssembly.Memory in computeMemoryCost()
- #44759 HTMLRewriter: park a suspended handler's token before the
output flush
- #44907 Builtins section format 2: an engine stamp says which buns
compile its modules
- #45188 Reject an oversized WebCrypto cipher output instead of aborting
- #45354 Throw for a `file:` URL whose path is not UTF-8 on Linux and
macOS, through one `fileSystemPath()` accessor *(crash fix only)*
- #45608 ipc: refuse an over-long message before the receive buffer
stores it
- #45624 webcrypto: write the key type into the X25519 structured-clone
record
- #45625 node:sqlite: refuse session.close() and Symbol.dispose inside a
SQLite callback
- #45653 glob: a group with `?` or a class matches when an alternative
takes 64 bytes or more
- #45820 Bun.file, S3Client.file and Bun.write no longer keep a buffer
path alive forever
- #45832 `bun check`: fix a panic on `export *` without a module
specifier, and a false error for one in parentheses

### Already fixed on `main`, or duplicates of a pull request above

Already fixed: #27323 #30401 #31011 #31206 #31566 #31626 #31695 #31702
#31945 #32773 #34154 #34697 #34744 #34964 #35655 #35816 #36020 #36181
#36296 #36342 #36581 #36602 #36807 #36818 #36857 #37172 #37235 #37239
#37267 #37420 #37731 #37914 #38113 #38119 #38509 #38514 #38540 #38975
#39410 #40749 #41163 #41171 #42108 #43085 #43230

Duplicates: #45654 #29986 #33378 #36895 #37070 #37639 #38014 #39021
#41266 #42250 #42951 #43238 #44259 #45335 #45565 #45726 #45965

Fixes #5019
Fixes #6106
Fixes #10690
Fixes #10886
Fixes #13566
Fixes #14745
Fixes #15551
Fixes #20454
Fixes #21310
Fixes #29145
Fixes #30454
Fixes #30613
Fixes #30766
Fixes #32103
Fixes #32142
Fixes #32183
Fixes #32212
Fixes #39060
Fixes #42296
Fixes #42931
Fixes #43671
Fixes #44201
Fixes #44735
Fixes #44783
Fixes #45198
Fixes #45327
Fixes #45491
Fixes #45721

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants